Fix for multiple ENV variables sharing the same bref-ssm: parameters#9
Open
selfsimilar wants to merge 2 commits intobrefphp:mainfrom
Open
Fix for multiple ENV variables sharing the same bref-ssm: parameters#9selfsimilar wants to merge 2 commits intobrefphp:mainfrom
selfsimilar wants to merge 2 commits intobrefphp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the unlikely (but definitely encountered) event that multiple
ENVvariables share the samebref-ssm:parameter, prior to this fix, only the first declaredENVvariable would be replaced. SubsequentENVvariables would contain thebref-ssm:/exampletoken.This simple fix is to iterate over
$envVarsToDecryptinstead of$parameters, since there's no guarantee of a 1:1 relationship.The biggest change is a refactor to the tests. I had to slot the new test before
test throws a clear error message on missing permissions()because I couldn't getSOME_VARIABLE=bref-ssm:/app/testto clear before running the next test. I spent some time trying to clear the setENVvariables (setenv('SOME_VARIABLE');) but that didn't seem to help. Regardless, the tests run clean now.